Update liberfa to v2.0.1 and prepare for release. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the procedure might be to merge this PR (assuming tests pass), then fix the astropy failures in its |
avalentino
approved these changes
Oct 13, 2023
|
Thanks for the quick review! I'll go ahead and merge this, and then make a PR for astropy to fix the failing test. |
|
See astropy/astropy#15476 for the astropy PR. Once that is in, I think we can release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively the 2.0.1 release, but running it through tests first.
Because of a bugfix of
pvstarin SOFA, one of the astropy tests fails with it. We should check how to handle that before actually releasing this.