Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOCKCHAIN-94 - Bridge: Minimum transfer amount requirement #305

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

kacperzuk-neti
Copy link
Collaborator

No description provided.

@kacperzuk-neti kacperzuk-neti force-pushed the BLOCKCHAIN-94/min_bridge_transfer branch from 5a93c72 to 6fad183 Compare July 26, 2023 09:29
@kacperzuk-neti kacperzuk-neti changed the title Bridge: Minimum transfer amount requirement BLOCKCHAIN-94 - Bridge: Minimum transfer amount requirement Jul 26, 2023
* there's a delay between approval of mint and actually allowing it

## Official deployments

Sepolia testnet (meant to be used with Liberland Bastiat testnet):

```
LDN ERC-20 token: 0x195E89cdE9475e18DB594A24FC2954235d7F4e92
LDN ERC-20 token: 0x0f018D7e0B8f5D5cCc88c0B23d931AaAA13B0C42
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, this should be part of https://github.com/liberland/liberland_substrate/pull/304/files .
Will clean this from this PR.
As to why: old token contract required explicit allowance granted to be used with bridge by each token holder. New version allows bridge use automatically.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these changes from this PR.

@kacperzuk-neti
Copy link
Collaborator Author

Approved by Dorian on chat.

@kacperzuk-neti kacperzuk-neti merged commit 71a1282 into develop Jul 26, 2023
4 checks passed
@kacperzuk-neti kacperzuk-neti deleted the BLOCKCHAIN-94/min_bridge_transfer branch July 31, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants