BLOCKCHAIN-161 - Referendum concerning Constitution - verify tallying #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalLustykNeti
requested review from
DorianSternVukotic and
kacperzuk-neti
and removed request for
DorianSternVukotic
MichalLustykNeti
force-pushed
the
BLOCKCHAIN-161-referendum-concerning-constitution-verify-tallying
branch
from
9fbed6f
to
b6683ca
Compare
kacperzuk-neti
approved these changes
Sep 19, 2023
kacperzuk-neti
requested changes
Sep 20, 2023
There was a problem hiding this comment.
What about Frontend, does it handle this threshold in any way?
If it does, does it already expect 2/3 or is there a PR to fix it?
If it doesn't, can you create a JIRA issue for that? I guess it should at least be handled somehow on the list of referendum, where it shows if it currently has enough votes to pass or not.
Done task on JIRA created |
kacperzuk-neti
approved these changes
Sep 22, 2023
kacperzuk-neti
force-pushed
the
BLOCKCHAIN-161-referendum-concerning-constitution-verify-tallying
branch
from
b6683ca
to
6458fd6
Compare
DorianSternVukotic
approved these changes
Oct 5, 2023
kacperzuk-neti
deleted the
BLOCKCHAIN-161-referendum-concerning-constitution-verify-tallying
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FE PR: liberland/liberland_frontend#142