Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLOCKCHAIN-187 - Senate Veto during Enactment Period #334

Merged
merged 1 commit into from
Nov 9, 2023
Merged

BLOCKCHAIN-187 - Senate Veto during Enactment Period #334

merged 1 commit into from
Nov 9, 2023

Conversation

MichalLustykNeti
Copy link
Collaborator

No description provided.

@MichalLustykNeti MichalLustykNeti self-assigned this Oct 12, 2023
@MichalLustykNeti MichalLustykNeti changed the base branch from main to develop October 12, 2023 12:06
@MichalLustykNeti MichalLustykNeti marked this pull request as draft October 12, 2023 12:37
@MichalLustykNeti MichalLustykNeti force-pushed the BLOCKCHAIN-187-senate-veto-during-enactment-period branch from 9f95025 to 887a989 Compare October 17, 2023 15:21
@MichalLustykNeti MichalLustykNeti marked this pull request as ready for review October 17, 2023 15:22
kacperzuk-neti
kacperzuk-neti requested changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@kacperzuk-neti kacperzuk-neti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work for me.
image
How should I test it to make it work?

bin/node/runtime/src/impls.rs Outdated Show resolved Hide resolved
bin/node/runtime/src/impls.rs Outdated Show resolved Hide resolved
@kacperzuk-neti
Copy link
Collaborator

Fix commit msg.

@MichalLustykNeti MichalLustykNeti force-pushed the BLOCKCHAIN-187-senate-veto-during-enactment-period branch 2 times, most recently from 9eb3dbb to 699b7d7 Compare October 31, 2023 14:37
@MichalLustykNeti MichalLustykNeti force-pushed the BLOCKCHAIN-187-senate-veto-during-enactment-period branch from 699b7d7 to 0531edd Compare October 31, 2023 14:47
@kacperzuk-neti kacperzuk-neti merged commit e9b6bb9 into develop Nov 9, 2023
@kacperzuk-neti kacperzuk-neti deleted the BLOCKCHAIN-187-senate-veto-during-enactment-period branch November 9, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacperzuk-neti kacperzuk-neti kacperzuk-neti approved these changes

@DorianSternVukotic DorianSternVukotic DorianSternVukotic approved these changes

Assignees

@MichalLustykNeti MichalLustykNeti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalLustykNeti @kacperzuk-neti @DorianSternVukotic