Make tests optional.

[lnd3]

When using fann as a cmake submodule, you are forced to create fann test targets, including support targets, which includes gtest and gmock.
This is undesirable.

[geekgirljoy]

I agree that pulling in gtest and gmock by default is undesirable. Fewer external dependencies make builds simpler and more flexible, and personally I don’t use those frameworks myself.

That said, I think the more important question is whether anyone in the user base does rely on them. If they’re not serving an active purpose, then dropping them is a no-brainer. But if some people do benefit, it might be worth understanding how and why before making a final decision.

I definitely support the idea that when FANN is included as a submodule, its tests... and by extension gtest/gmock - shouldn’t be forced on downstream projects. Tests should be opt-in, not opt-out. I’ll defer to the broader consensus here, since gtest/gmock aren’t part of my day-to-day toolchain, but I’d be interested to hear if others have a strong use case for keeping them enabled by default.

I vote, soft yes.