Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill stat info when returning cached data for readdir #306

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 17, 2024

  1. Fill stat info when returning cached data for readdir

    Uncached and cached results for readdir were inconsistent -- the former
    returned correct stat info for directory entries while the latter
    didn't. That's because only names of entries were saved in cache without
    stat info. In turn this leads to issues like
    junegunn/fzf#3832 since directory traversal
    library (https://github.com/charlievieth/fastwalk in this case) relies
    on proper stat info returned by readdir. Hence when unchached result was
    returned it gave proper outcome, while with cached result it was wrong.
    
    Cache stat info next to entry name to fix the issue. While file
    attributes are saved in cache already, they use full path as key. To
    avoid potentially plenty of allocations, string copying and cache
    lookups to get each attr, let's keep a copy of stat struct independently
    to be on the fast path.
    jpalus committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    5f767de View commit details
    Browse the repository at this point in the history