Fix bug of GeoJSONWriter when there are sub-objects or sub-array in an array #1216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeoJSONWriter will throw exception when handle these two cases:
the message of the exception is :
The root cause is here:
https://github.com/libgeos/geos/blob/3.13.0/src/io/GeoJSONWriter.cpp#L112
https://github.com/libgeos/geos/blob/3.13.0/src/io/GeoJSONWriter.cpp#L118
All other scalar types will detect the parent node is object or array.
If the parent is object then use key to add child value, else use push_back.
But when it comes to value.is_array() and value.is_object(), we forget to detect the type of parent json node.
So I add two unit tests to trigger the bug and fix it.