Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not access freed memory in test_push_options() #1304

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Do not access freed memory in test_push_options() #1304

merged 1 commit into from
Jun 11, 2024

Conversation

kempniu
Copy link
Contributor

@kempniu kempniu commented Jun 10, 2024

Fixes #1301

@kempniu kempniu mentioned this pull request Jun 10, 2024
Closed
@kempniu
Copy link
Contributor Author

kempniu commented Jun 10, 2024

@anatol, could you please test whether this addresses the issue you reported in #1301?

@anatol
Copy link

anatol commented Jun 10, 2024

This patch makes the ASAN-enabled tests happy. Thank you for the fix.

@jdavid jdavid merged commit 5b27dee into libgit2:master Jun 11, 2024
7 checks passed
@kempniu kempniu deleted the do-not-access-freed-memory-in-test_push_options branch June 11, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault at test_push_options()
3 participants
@kempniu @anatol @jdavid