libical-glib: Fix typedef redefinition #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The i-cal-forward-declarations.h and the respective object file both had "typedef struct _ObjName ObjName;" which is not allowed before C standard 11. Rather than depend on it, inline the glib macro without the offending typedef, allowing to have it split in a common header. Closes libical#1096
|
This is the simplest change. I've been thinking of adding needed headers into the respective API files, then I realized there are some cross-includes, which would need to change all Maybe it would be a cleaner solution, but harder to follow, I'm afraid. The disadvantage is that the type declarations will not follow any changes made in the glib in the |
winterz
approved these changes
Oct 14, 2025
|
Okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The i-cal-forward-declarations.h and the respective object file both had "typedef struct _ObjName ObjName;" which is not allowed before C standard 11. Rather than depend on it, inline the glib macro without the offending typedef, allowing to have it split in a common header.
Closes #1096