Allow password to be skipped or set to None in add_entry #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Allow skipping password or
password=None
inadd_entry
This PR fixes an issue where skipping or passing
None
as thepassword
toadd_entry
would raise aTypeError
, due tolxml
not acceptingNone
when building XML elements.According to the documentation:
https://libkeepass.github.io/pykeepass/pykeepass.html#PyKeePass.add_entry
The documentation already states that
None
is allowed, but the code did not support it.What this PR does
<Password>
field entirely ifpassword
isNone