Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when we run OCCA tests, they use the automatically generated
*_codegen
files from the build directory. This is because, we do the following two things:
-I${OCCA_INSTALL_DIR}
is added to the compile command indevice::buildKernel()
methods.
OCCA_INSTALL_DIR
is not defined, it defaults toOCCA_BUILD_DIR
.Since we never set
OCCA_INSTALL_DIR
, we have always been using*_codegen
files fromthe build directory. When I tried running the tests by setting
OCCA_INSTALL_DIR
, I getcompilation errors since we don't have the required
*_codegen
files at the correct placesin the install directory. This PR fixes this issue.
PS: I only tested theCMake
build for now. May need fixes for theGNU Make
build.Todo
OCCA_INSTALL_DIR
set.