Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing includes #775

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

thilinarmtb
Copy link
Collaborator

@thilinarmtb thilinarmtb commented Nov 20, 2024

Description

Currently, when we run OCCA tests, they use the automatically generated *_codegen
files from the build directory. This is because, we do the following two things:

  • -I${OCCA_INSTALL_DIR} is added to the compile command in device::buildKernel()
    methods.
  • If OCCA_INSTALL_DIR is not defined, it defaults to OCCA_BUILD_DIR.

Since we never set OCCA_INSTALL_DIR, we have always been using *_codegen files from
the build directory. When I tried running the tests by setting OCCA_INSTALL_DIR, I get
compilation errors since we don't have the required *_codegen files at the correct places
in the install directory. This PR fixes this issue.

PS: I only tested the CMake build for now. May need fixes for the GNU Make build.

Todo

  • Run the GitHub CI tests with OCCA_INSTALL_DIR set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant