Avoid -fsycl being added to non-SYCL code
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thilinarmtb
changed the title
-fsycl getting added to non-SYCL code-fsycl being added to non-SYCL code
thilinarmtb
force-pushed
the
remove-sycl-flags-when-compiling-sycl
branch
from
04eb8d1 to
ebfd9fb
Compare
thilinarmtb
force-pushed
the
remove-sycl-flags-when-compiling-sycl
branch
from
ebfd9fb to
20714a6
Compare
thilinarmtb
commented
Nov 21, 2024
| set_target_properties(OCCA::depends::DPCPP PROPERTIES | ||
| INTERFACE_INCLUDE_DIRECTORIES "${SYCL_INCLUDE_DIRS}" | ||
| INTERFACE_INCLUDE_DIRECTORIES "${SYCL_INCLUDE_DIR};${SYCL_INCLUDE_DIR}/sycl" |
There was a problem hiding this comment.
Should we add ${SYCL_INCLUDE_DIR}/CL here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current
developmentversion,FindDPCPP.cmakeadds-fsyclto thehost (one that is being used to compile OCCA) compiler. This results in compilation
errors if the host compiler doesn't support SYCL. There is no need for the host
compiler to support SYCL to use the OCCA SYCL backend. Users simply has to
set the following variables: