Ownership support for volumes #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ownership adds the management of the Ownership object in the volume spec, which is used to determine permissions on access to a volume. Signed-off-by: Luis Pabón <[email protected]>
lpabon
force-pushed
the
ownership-oidc2
branch
2 times, most recently
from
fc519d8
to
2bd2528
Compare
ptheunis
approved these changes
Jan 15, 2019
pkg/auth/userinfo.go
Outdated
| @@ -32,19 +29,24 @@ const ( | |||
| InterceptorContextTokenKey InterceptorContextkey = "tokenclaims" | |||
| ) | |||
|
|
|||
| // UserInfo contins information about the user taked from the token | |||
| fmt.Errorf("Failed to find volume mapping for %v", req.MountPath) | ||
| volid := resp.GetVolume().GetId() | ||
|
|
||
| // TODO: Idempotency? |
| @@ -343,6 +366,9 @@ func (s *CloudBackupServer) SchedDelete( | |||
| return nil, status.Error(codes.Unavailable, "Resource has not been initialized") | |||
| } | |||
|
|
|||
| // TODO | |||
| @@ -261,6 +276,9 @@ func (s *CloudBackupServer) StateChange( | |||
| return nil, status.Error(codes.Unavailable, "Resource has not been initialized") | |||
| } | |||
|
|
|||
| // TODO | |||
| @@ -190,6 +195,10 @@ func (s *CloudBackupServer) Status( | |||
| return nil, status.Error(codes.Unavailable, "Resource has not been initialized") | |||
| } | |||
|
|
|||
| // XXX Check ownership | |||
lpabon
force-pushed
the
ownership-oidc2
branch
from
2bd2528
to
233c32a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ownership adds the management of the Ownership object in the
volume spec, which is used to determine permissions on access
to a volume.
Which issue(s) this PR fixes (optional)
Part of #448
Special notes for your reviewer: