feat(rust-libp2p): update required jobs

[thomaseizinger]

Summary

Companion PR for libp2p/rust-libp2p#4880.

Why do you need this?

What else do we need to know?

DRI: myself

Reviewer's Checklist

• It is clear where the request is coming from (if unsure, ask)
• All the automated checks passed
• The YAML changes reflect the summary of the request
• The Terraform plan posted as a comment reflects the summary of the request

[github-actions]

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_branch_protection.this["rust-libp2p:master"] will be updated in-place
  ~ resource "github_branch_protection" "this" {
        id                              = "MDIwOkJyYW5jaFByb3RlY3Rpb25SdWxlMjM0NjQ0MA=="
        # (11 unchanged attributes hidden)

      ~ required_status_checks {
          ~ contexts = [
              + "Compile libp2p in transport feature matrix",
              + "Compile libp2p-identity in feature matrix",
              - "Compile with select features (mdns tcp dns async-std)",
              - "Compile with select features (mdns tcp dns tokio)",
                # (55 unchanged elements hidden)
            ]
            # (1 unchanged attribute hidden)
        }

        # (1 unchanged block hidden)
    }

  # github_repository_file.this["py-libp2p/.github/workflows/stale.yml"] will be updated in-place
  ~ resource "github_repository_file" "this" {
      + commit_author       = "GitHub"
      + commit_email        = "[email protected]"
        id                  = "py-libp2p/.github/workflows/stale.yml"
        # (9 unchanged attributes hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

[thomaseizinger]

Not sure what this is doing in my PR?

[mxinden]

@achingbrain @galargh do you why automation pushed these changes to an unrelated pull request?

[galargh]

The automation runs https://github.com/libp2p/github-mgmt/blob/master/scripts/src/actions/fix-yaml-config.ts after every push to the default branch and on every PR.

The reason why unrelated changes were pushed to the PR was that #197 has not been merged. The timeline would be, 1. the sync workflow discovers divergence between what's in this repo and the actual GitHub state, 2. the repo gets updated, 3. the PR with fixes is created but not merged, 4. this PR is created, 5. the fixes are also proposed in this PR because the PR with fixes was not merged yet.

Another thing to note is that once a fix PR is merged, then all the existing PRs are rebased which would have got rid of the unrelated changes.

It is a bit clunky at the moment. I'd like to package the workflows that do the actual work in this repo into nice reusable actions so it'd be easier for users to reason about and customise what happens when. There's no timeline for that work though.

Another issue, the commits with fixes are associated with PR owner at the moment which shouldn't be the case as they are bot commits. I created an issue for that here - ipdxco/github-as-code#110

[mxinden]

@thomaseizinger do I understand correctly, that you want this merged? (libp2p/rust-libp2p#4880 (comment))

If so, can you confirm and set it to "Ready for review"?

[p-shahi]

lgtm @thomaseizinger

[thomaseizinger]

lgtm @thomaseizinger

Thanks! The merge queue on rust-libp2p is currently stuck so please don't merge this yet. I'll ping again when it is ready.

[galargh]

Closing since it's been stale for a while. Please reopen if it's still needed.