reject messages claiming to be from ourselves but not locally published #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @mystical-prog ! Would it be possible to add a test showing that such a message is properly dropped? |
|
Sure, I will add a test and get back to you. |
|
hey @pacrob |
|
Looks good, @mystical-prog ! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There was a missing check in
push_msgfunction inside thepubsubmodule wherein we weren't rejecting messages claiming to be from ourselves but not locally publishedCloses #413
How was it fixed?
I took a reference from
go-libp2p-pubsubimplementation and added the missing checkTo-Do
testsmake lintnewsfragmentCute Animal Picture