remove unnecessary allow-deprecated

libp2p · Dec 10, 2024 · 191ab0e · 191ab0e
1 parent 0bf737f
commit 191ab0e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/swarm/benches/connection_handler.rs b/swarm/benches/connection_handler.rs
@@ -268,7 +268,6 @@ struct SpinningHandler {
     protocols: &'static [StreamProtocol],
 }
 
-#[allow(deprecated)]
 impl ConnectionHandler for SpinningHandler {
     type FromBehaviour = Infallible;
 

diff --git a/swarm/src/connection.rs b/swarm/src/connection.rs
@@ -155,9 +155,9 @@ where
     max_negotiating_inbound_streams: usize,
     /// Contains all upgrades that are waiting for a new outbound substream.
     ///
-    /// The upgrade timeout is already ticking here so this may fail in case the remote is not quick
+    /// The upgrade timeout is already ticking here so this may fail in case the remote is not
     /// quick enough in providing us with a new stream.
-    #[allow(deprecated)]
+    #[allow(deprecated)] // TODO: Remove when {In, Out}boundOpenInfo is fully removed.
     requested_substreams: FuturesUnordered<
         SubstreamRequested<THandler::OutboundOpenInfo, THandler::OutboundProtocol>,
     >,

diff --git a/swarm/src/handler.rs b/swarm/src/handler.rs
@@ -113,10 +113,10 @@ pub trait ConnectionHandler: Send + 'static {
     /// The outbound upgrade for the protocol(s) used by the handler.
     type OutboundProtocol: OutboundUpgradeSend;
     /// The type of additional information returned from `listen_protocol`.
-    #[deprecated]
+    #[deprecated = "Track data in ConnectionHandler instead."]
     type InboundOpenInfo: Send + 'static;
     /// The type of additional information passed to an `OutboundSubstreamRequest`.
-    #[deprecated]
+    #[deprecated = "Track data in ConnectionHandler instead."]
     type OutboundOpenInfo: Send + 'static;
 
     /// The [`InboundUpgrade`](libp2p_core::upgrade::InboundUpgrade) to apply on inbound