Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated iOS interface in swift FFI bindings #5628

Open
RawinSader opened this issue Oct 8, 2024 · 0 comments · May be fixed by #5758
Open

Deprecated iOS interface in swift FFI bindings #5628

RawinSader opened this issue Oct 8, 2024 · 0 comments · May be fixed by #5758

Comments

@RawinSader
Copy link

Summary

Libp2p relies on a package called [email protected] in 4 different places:

transport/tcp
transport/quic
transport/webrtc
protocol/mdns

This unmaintained library uses a deprecated iOS interface through one of its own dependencies `[email protected]:

https://discuss.libp2p.io/t/rust-libp2p-link-error-on-ios-undefined-symbols-kscnetworkinterfacetypeirda/2208

https://github.com/libp2p/rust-libp2p/issues/5140

Seeing that our bindings use this deprecated interface, iOS apps will fail to build for everyone using rust-libp2p.

Expected behavior

When adding the sdk.xcframework and the sdk.swift that we generate to be used inside the iOS app, the build works as there are no deprecated traits used

Actual behavior

When adding the sdk.xcframework and the sdk.swift that we generate to be used inside the iOS app, the build fails due to an undefined symbol _kSCNetworkInterfaceTypeIrDA

Relevant log output

No response

Possible Solution

The solution would be to update the system-configuration dependecy of the if-watch crate seeing if-watch is directly used in the libp2p repository

MR: #5624

Version

0.54.1

Would you like to work on fixing this bug ?

Yes

@brenodt brenodt linked a pull request Dec 23, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant