-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(if-watch): update if-watch to v3.2.1 #5758
base: master
Are you sure you want to change the base?
Conversation
This pull request has merge conflicts. Could you please resolve them @brenodt? 🙏 |
…on deprecation issue on ios
377afdc
to
47679a9
Compare
47679a9
to
a2ac9f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has merge conflicts. Could you please resolve them @brenodt? 🙏 |
caea2bc
to
528723d
Compare
Hi @elenaf9 , thanks for the review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks for your PR! I don't think we even need a version bump right? As even the end user can update by doing cargo upgrade -p if-watch
and it will update if-watch
to 3.2.1
Description
Bumps the
if-watch
version to 3.2.1, aiming to fix #5628.Since this
if-watch
PR, thesystem-configuration
version has been updated, which enables compiling for iOS targets.Notes & open questions
I'm not sure if I should update the changelogs to include the PR link?
Also, should the main libp2p version be bumped to 0.54.3?
I don't see 0.54.2 in crates, so I wasn't sure, but did it anyway to enable testing locally.
This change made possible compiling for
aarch64-apple-ios-sim
via cargo lipo and using the resulting static lib without XCode complaining about the deprecated interface.Change checklist