ci(semver-checks): avoid stale caches after rustc or tool upgrade #3664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid the cache getting stale with changes in rustdoc format.
thomaseizinger
changed the title
obi1kenobi
reviewed
Mar 22, 2023
Co-authored-by: Predrag Gruevski <[email protected]>
mxinden
approved these changes
Mar 24, 2023
mergify
bot
deleted the
fix/version-semver-checks-cache-with-rust-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With an upgrade to the Rust toolchain, the version of the rustdoc JSON may change. We incorporate the rustc version into the cache key to automatically invalidate the cache in that case. Additionally, we also incorporate the version of the
cargo semver-checkstool.Related: obi1kenobi/cargo-semver-checks#415.
Notes & open questions
Change checklist