Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Experimental CI tests on Apple Platforms #5528

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

umgefahren
Copy link
Contributor

  • Properly handle common issue with IPv6 mdns on macOS (and all other apple platforms
  • First iteration of Apple CI

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@umgefahren umgefahren changed the title enhancement(ci): Experimental CI tests on iOS ci: Experimental CI tests on Apple Platforms Aug 4, 2024
@jxs
Copy link
Member

jxs commented Oct 18, 2024

Hi Hannes, thanks for this! Tbh I am torn if we want to make apple a first tier target and spend CI with it. Opinions @dariusc93 @guillaumemichel?

@guillaumemichel
Copy link
Contributor

If it doesn't add too much CI and maintenance overhead, IMO it is nice to have. I guess many developers are building from macOS.

What is the expected CI overhead?

@dariusc93
Copy link
Member

If it doesn't add too much CI and maintenance overhead, IMO it is nice to have. I guess many developers are building from macOS.

I agree if it doesnt add to much overhead I dont see a problem with it. It would be a nice-to-have sort of thing though.

@jxs
Copy link
Member

jxs commented Oct 30, 2024

ok nice, since you agree let's go ahead :) @umgefahren can you see what's happening with CI?
thanks!

@umgefahren
Copy link
Contributor Author

I will take a look at it once I have more bandwidth.
As I filed this I think the errors are routed somewhere down in the dependency tree. I started filing PRs (I think some were already merged) others I still have to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants