Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update MSRV #5650

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: update MSRV #5650

wants to merge 3 commits into from

Conversation

jxs
Copy link
Member

@jxs jxs commented Oct 25, 2024

No description provided.

dariusc93
dariusc93 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we would need to bump the minor version would we not? Besides that I do agree with the bump in msrv

@jxs
Copy link
Member Author

jxs commented Oct 25, 2024

I believe we would need to bump the minor version would we not? Besides that I do agree with the bump in msrv

right let's wait for the next major version release cycle before merging this, thanks Darius!

@dariusc93
Copy link
Member

Will mark this as a draft for now until the next window

@dariusc93 dariusc93 marked this pull request as draft October 25, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@guillaumemichel guillaumemichel guillaumemichel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jxs @dariusc93 @guillaumemichel