Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused deps #5747

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Dec 17, 2024

Description

Remove unused dependencies

(Not sure how to bump libp2p-identity and libp2p-swarm-derive versions in a PR)

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@hanabi1224 hanabi1224 force-pushed the unused-deps branch 3 times, most recently from 16a1e20 to 8815c47 Compare December 17, 2024 10:26
@hanabi1224 hanabi1224 marked this pull request as ready for review December 17, 2024 10:28
@jxs jxs changed the title fix(deps): remove unused deps chore(deps): remove unused deps Dec 17, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! <3 overall looks good to me, I don't think we need CHANGELOG.md entries and consequent Cargo.toml updates

@hanabi1224
Copy link
Contributor Author

Thanks for this! <3 overall looks good to me, I don't think we need CHANGELOG.md entries and consequent Cargo.toml updates

@jxs reverted changelogs

jxs
jxs previously approved these changes Dec 23, 2024
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@jxs jxs added the send-it label Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #5747 has been dequeued. The pull request has been synchronized by a user

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed jxs’s stale review December 23, 2024 14:19

Approvals have been dismissed because the PR was updated after the send-it label was applied.

jxs
jxs previously approved these changes Dec 23, 2024
Copy link
Contributor

mergify bot commented Dec 23, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot dismissed jxs’s stale review December 24, 2024 04:31

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit 7590ab2 into libp2p:master Dec 24, 2024
71 checks passed
@hanabi1224 hanabi1224 deleted the unused-deps branch December 24, 2024 09:32
jxs pushed a commit to jxs/rust-libp2p that referenced this pull request Jan 6, 2025
Remove unused dependencies

(Not sure how to bump `libp2p-identity` and `libp2p-swarm-derive` versions in a PR)

Pull-Request: libp2p#5747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants