Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gossipsub): Allow setting a size threshold for IDONTWANT messages #5770

Merged
merged 5 commits into from
Dec 29, 2024
Merged

feat(gossipsub): Allow setting a size threshold for IDONTWANT messages #5770

merged 5 commits into from
Dec 29, 2024
+77 −3

Conversation

hopinheimer
Copy link
Contributor

Description

This PR adds configurable parameter that sets minimum message size for which IDONTWANT messages would be send. This is an optimisation trick, discussion regarding the same can be found here

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@hopinheimer
Copy link
Contributor Author

#5769 will be needed to pass ci

@jxs jxs changed the title feat(gossipsub): Add configurable idontwant_message_size_threshold param feat(gossipsub): Allow setting a message size threshold for which IDONTWANT messages are sent Dec 28, 2024
@jxs jxs changed the title feat(gossipsub): Allow setting a message size threshold for which IDONTWANT messages are sent feat(gossipsub): Allow setting a message size threshold for IDONTWANT messages Dec 28, 2024
@jxs jxs changed the title feat(gossipsub): Allow setting a message size threshold for IDONTWANT messages feat(gossipsub): Allow setting a size threshold for IDONTWANT messages Dec 28, 2024
jxs
jxs reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started Hoppinheimer! We also need a function in Config to allow setting the threshold right?

protocols/gossipsub/src/behaviour.rs Show resolved Hide resolved
jxs
jxs approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hopinheimer LGTM!

@jxs jxs added the send-it label Dec 29, 2024
@mergify mergify bot merged commit e1d02ca into libp2p:master Dec 29, 2024
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopinheimer @jxs