Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(quic): deprecate QUIC draft-29 version support #5786

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

chore(quic): deprecate QUIC draft-29 version support #5786

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
538e2ff
feat: deprecated support_draft_29 field
tesol2y090 Dec 31, 2024
2a95c84
feat: update changelog
tesol2y090 Dec 31, 2024
5958303
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Dec 31, 2024
01552a7
feat: move changelog under 0.11.2
tesol2y090 Jan 1, 2025
5596502
chore: add allow deprecated on support_draft_29
tesol2y090 Jan 1, 2025
4cfd7eb
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Jan 3, 2025
d3e6a02
Merge branch 'master' into feat/quic/deprecated-draft-29
tesol2y090 Jan 28, 2025
b802f05
feat: use expect instead of allow
tesol2y090 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions transports/quic/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
- Deprecate `void` crate.
See [PR 5676](https://github.com/libp2p/rust-libp2p/pull/5676).

- Deprecate `Config::support_draft_29`.
See [PR 5786](https://github.com/libp2p/rust-libp2p/pull/5786).

## 0.11.1

- Update `libp2p-tls` to version `0.5.0`, see [PR 5547]
Expand Down
1 change: 1 addition & 0 deletions transports/quic/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
/// If support for draft-29 is enabled servers support draft-29 and version 1 on all
/// QUIC listening addresses.
/// As client the version is chosen based on the remote's address.
#[deprecated(note = "QUIC draft versions are no longer supported")]
pub support_draft_29: bool,

/// TLS client config for the inner [`quinn::ClientConfig`].
Expand All @@ -85,7 +86,7 @@
Self {
client_tls_config,
server_tls_config,
support_draft_29: false,

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Check rustdoc intra-doc links 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Compile on x86_64-apple-darwin 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / clippy (1.83.0) 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / clippy (beta) 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / examples 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Compile with MSRV 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p-quic 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p-perf 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 89 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p-server 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported
handshake_timeout: Duration::from_secs(5),
max_idle_timeout: 10 * 1000,
max_concurrent_stream_limit: 256,
Expand Down Expand Up @@ -132,7 +133,7 @@
keep_alive_interval,
max_connection_data,
max_stream_data,
support_draft_29,

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Check rustdoc intra-doc links 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Compile on x86_64-apple-darwin 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / clippy (1.83.0) 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / clippy (beta) 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / examples 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Compile with MSRV 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p-quic 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p-perf 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported

Check failure on line 136 in transports/quic/src/config.rs

View workflow job for this annotation

GitHub Actions / Test libp2p-server 

use of deprecated field `config::Config::support_draft_29`: QUIC draft versions are no longer supported
handshake_timeout: _,
keypair,
mtu_discovery_config,
Expand Down
Loading