chore: deprecate async_std support in swarm crate #5957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
reviewed
Apr 29, 2025
yup it should work now |
elenaf9
reviewed
Apr 30, 2025
| @@ -12,24 +12,7 @@ use libp2p_swarm::{ | |||
| }; | |||
| use libp2p_swarm_test::SwarmExt; | |||
|
|
|||
| #[async_std::test] | |||
There was a problem hiding this comment.
Please change this to use tokio, instead of removing the test.
|
This pull request has merge conflicts. Could you please resolve them @gitToki? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #5935
crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.