Various fixes #9
Conversation
| @@ -1,6 +1,5 @@ | |||
| use libc::{c_int, c_uint, c_ulong, c_char, timeval, ssize_t}; | |||
| use libc::{c_int, c_uint, c_ulong, c_char, timeval, ssize_t, IF_NAMESIZE }; | |||
There was a problem hiding this comment.
Could you remove the space before the } here please?
|
If you follow that thread through, it looks like there's a workaround for getting alignment right, using simd types - rust-lang/rfcs#325 (comment) - is this an option here? |
|
Simd is experimental and not available on stable rust. |
|
I guess the real question is: do the alignment issues matter? Does it actually affect anything on the Rust side? If yes, perhaps it would be worth just using an array, and providing accessors/mutators to get at the misaligned fields, at least until Rust has native support? |
|
As far as I understand it's only a performance optimization and matters only in case we allocated it on the stack. We receive a pointer to it, so alignment is not our business. |
|
As long as everything works correctly on our end I'm happy. Thank you again for your work on this. |
These were mostly uncovered by ctest.
The biggest problem is in netmap_ring, i.e. functions operating on slots don't work without it.
cteststill reports alignment problems, but it looks like this is impossible to solve in today's rust (rust-lang/rfcs#1358).