Fw upgrade one click #276
Closed
Fw upgrade one click #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using react-query server state data is treated as such, decoupling it from global UI state given by app context
the code was using an incorrect instance of queryCache, so where the tests.
only apply to the current version, and appear again for the next one
|
CI is failing at storybook build, because of a simple typo in the storybook repo, which will be solved when storybookjs/storybook#12883 gets merged. |
Also, always try to login as root automatically before asking for password
This was referenced Oct 24, 2020
Closed
Merged
|
Wow this is huge! Thanks @germanferrero! |
By using react-query server state data is treated as such, decoupling it from global UI state given by app context
the code was using an incorrect instance of queryCache, so where the tests.
only apply to the current version, and appear again for the next one
germanferrero
force-pushed
the
fw-upgrade-one-click
branch
from
c182357 to
4934253
Compare
spiccinini
approved these changes
Nov 26, 2020
|
I close this, since all changes were added by merging #278. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for one-click installation in companion with libremesh/lime-packages#773
Also React Query is introduced to the code base. React query allows to separate server state handling logic from UI state. The best feature IMO being letting developers re-use server state data across components in a declarative way, without worrying about caching and de-duping.