Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo ubus-lime-groundrouting in lime-app's Makefile #1141

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ilario
Copy link
Member

@ilario ilario commented Nov 19, 2024

That typo was introduced in January 2019 with this commit 8fe8d05 part of #453

It causes this warning and error messages when building LibreMesh using the Buildroot method:

WARNING: Makefile 'package/feeds/libremesh/lime-app/Makefile' has a dependency on 'ubus-lime-grondrouting', which does not exist
 * pkg_hash_check_unresolved: cannot find dependency ubus-lime-grondrouting for lime-app

@ilario
Copy link
Member Author

ilario commented Nov 19, 2024

This error got revealed when testing #1139.

Using this fix, I also got rid of these other errors:

 * pkg_hash_fetch_best_installation_candidate: Packages for lime-app found, but incompatible with the architectures configured
 * opkg_install_cmd: Cannot install package lime-app.

Before the adoption of libremesh.mk in #1139 (see also #766) this is not failing as the same typo is present also in the Makefile (since 1b2d501). After #1139 the package name is taken from the directory name, where the typo is not present.

@a-gave
Copy link
Contributor

a-gave commented Nov 19, 2024

Thanks! I seem to have encountered this testing 1139 but skipped because building without lime-app.

@a-gave a-gave merged commit 0878431 into libremesh:master Nov 19, 2024
1 check passed
a-gave added a commit to a-gave/lime-packages that referenced this pull request Dec 7, 2024
fix typo from libremesh#1141 also in package ubus-lime-groundrouting
copy fix from libremesh#1140 also in job multi-arch-build.yml
ilario pushed a commit that referenced this pull request Dec 8, 2024
fix typo from #1141 also in package ubus-lime-groundrouting
copy fix from #1140 also in job multi-arch-build.yml
ilario pushed a commit to ilario/lime-packages that referenced this pull request Dec 11, 2024
fix typo from libremesh#1141 also in package ubus-lime-groundrouting
copy fix from libremesh#1140 also in job multi-arch-build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants