Fixes on ubus-lime-utils #1143
Open
Fixes on ubus-lime-utils #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first and the third commits fix #956
I considered that the usage of watchping is not a real dependency of this package (this package does things even if watchping is not doing its things). So, rather than adding the dependency, I added a check for the existence of watchping (first commit).
The second commit is fixing a bug undetected since its introduction in 400ac95 within #890
The third commit is checking if the
client-wwaninterface exists before running ip on it.This could also be merged in the 2024.1 branch for the upcoming release.