Skip to content

Commit

Permalink
Run tests for macos-14 on arm64
Browse files Browse the repository at this point in the history
macos-12 and macos-13 fails `make test` on arm64 but macos-14 does not.
Hence this patch enables it on github action.
  • Loading branch information
nak3 committed Mar 21, 2024
1 parent ab8c8c2 commit 73787b1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ jobs:
run: ./scripts/test
env:
ARCH: "${{ matrix.arch }}"
OS: "${{ matrix.os }}"
8 changes: 6 additions & 2 deletions scripts/test
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ if [ `uname` = "Darwin" ]; then
cd build-static
cmake -DCMAKE_OSX_ARCHITECTURES=$ARCH ..
make -j 4
if [ "$ARCH" = "x86_64" ]; then
if [ "$ARCH" = "arm64" ] && [ "$OS" = "macos-12" ] || [ "$OS" = "macos-13" ]; then
echo "##### skip tests"
else
make test
fi
)
Expand All @@ -44,7 +46,9 @@ if [ `uname` = "Darwin" ]; then
cd build-shared
cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_OSX_ARCHITECTURES=$ARCH ..
make -j 4
if [ "$ARCH" = "x86_64" ]; then
if [ "$ARCH" = "arm64" ] && [ "$OS" = "macos-12" ] || [ "$OS" = "macos-13" ]; then
echo "##### skip tests"
else
make test
fi
)
Expand Down

0 comments on commit 73787b1

Please sign in to comment.