Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netpacket interface: Fix SRAM and client reconnecting #15797

Merged

Conversation

schellingb
Copy link
Contributor

Description

Working together with a core developer who is in the process of implementing the new netpacket libretro interface we found some issues in the frontend which this PR addresses.

  • When using the new core netpacket interface for netplay, don't synchronize the host SRAM to a joining client
  • Fix netplay connection not getting marked as reusable while the new core netpacket interface is enabled

Both issues and fixes are exclusive to cores that call RETRO_ENVIRONMENT_SET_NETPACKET_INTERFACE, which until now have yet to be used by a publicly built and released libretro core.

To recap, this new netpacket interface was added earlier this year in #15413. It allows a core to send and receive custom network packets, which can be used to implement a communication based multiplayer system instead of using the default state serialization based multiplayer. For example games with multiplayer that originally used wireless or ethernet based networking.

Related Pull Requests

#15413, #15434

…onize the host SRAM to a joining client

Fix netplay connection not getting marked as reusable while the new core netpacket interface is enabled
@LibretroAdmin LibretroAdmin merged commit d096eff into libretro:master Oct 13, 2023
22 checks passed
JoeOsborn pushed a commit to JoeOsborn/RetroArch that referenced this pull request Nov 2, 2023
…onize the host SRAM to a joining client (libretro#15797)

Fix netplay connection not getting marked as reusable while the new core netpacket interface is enabled
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this pull request Dec 26, 2024
…onize the host SRAM to a joining client (libretro#15797)

Fix netplay connection not getting marked as reusable while the new core netpacket interface is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants