-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] / [don't merge] Add support for scale_to = original in slang … #15937
Conversation
@HyperspaceMadness I know you've been interested in this capability for some time. |
Looks really good, we just need to get the other drivers covered then we're golden! @kokoko3k you may want to adjust your commit to keep all the original formatting except in the areas you changed code in,it will make this easier to review |
I've messed it a bit, btw, the readable commit is this ^_^ |
OK, so the only error that precludes all tests from passing is this -
If this can be addressed, we can proceed with this PR. |
gfx/drivers/gl2.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope I did right to use width and height instead of gl->tex_w and gl->tex_h
Can this PR be merged at this point? |
@LibretroAdmin it's only for glcore and vulkan currently (i.e., no d3d*). If that's okay, then it's probably fine. |
As defined in libretro/RetroArch#15937
As defined in libretro/RetroArch#15937
lol looks like librashader already merged "original" scale. We gotta keep up! :P |
closed by mistake |
…presets for vulkan and glcore drivers
Description
Retroarch supports source,viewport,absolute in shader presets, now it supports "original" too, which is handy for shader writers if they want to return to original dimensions after using anything but "source" in the previous passes.
Reviewers
@hunterk suggested me to open this as a draft, since i was unable to implement the feature for remaining output drivers.