Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail fixes #16062

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

zoltanvb
Copy link
Contributor

@zoltanvb zoltanvb commented Dec 31, 2023

Description

  • set standard name if only one entry is in the playlist
  • use first database name for thumbnails if core has multiple
  • edit: playlist thumbnail downloader was missed from Flexible thumbnail matching #16040, now it is added.

Related Pull Requests

First one ensures that old setup is used for ondemand thumbnail downloads in case of playlists with a single entry, since #16040 would start with the ROM name and fall back when flicking back and forth among playlist entries.
Second one finetunes #16025 in case when core supports multiple databases (such as snes9x).

- set standard name if only one entry is in the playlist
- use first database name for thumbnails if core has multiple
@zoltanvb zoltanvb marked this pull request as draft December 31, 2023 10:34
Playlist thumbnail downloader function was missed from the flexible
thumbnail name update, now it is added.
@zoltanvb zoltanvb marked this pull request as ready for review December 31, 2023 10:51
@zoltanvb zoltanvb changed the title Minor thumbnail improvements Thumbnail fixes Dec 31, 2023
@LibretroAdmin LibretroAdmin merged commit 8886b92 into libretro:master Jan 2, 2024
23 checks passed
@zoltanvb zoltanvb deleted the thumbnail_improvements branch January 20, 2024 15:44
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this pull request Dec 26, 2024
* Minor thumbnail improvements

- set standard name if only one entry is in the playlist
- use first database name for thumbnails if core has multiple

* Fix playlist thumbnail downloader

Playlist thumbnail downloader function was missed from the flexible
thumbnail name update, now it is added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants