Flexible thumbnail improvements. #16082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move flag logic to task_push_pl_entry_thumbnail_download - this enables individual "download thumbnails" entry to be also flexible - Add a message when this download has been tried enough times (i.e. 3) - Optimize cases when full or short name is the same as standard name, skip queries if so (both download and local file)
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
- Move flag logic to task_push_pl_entry_thumbnail_download - this enables individual "download thumbnails" entry to be also flexible - Add a message when this download has been tried enough times (i.e. 3) - Optimize cases when full or short name is the same as standard name, skip queries if so (both download and local file)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some improvements to flexible thumbnail naming, as a result of discussion under #16071
And done more testing to ensure that mix&match combinations and optimizations work as they should. Some notes on the testing environment, if anyone wants to replicate it:
python3 -m http.server) and change URL in file_path_special.h to http://127.0.0.1:8000thumbnail_testpack.zip
Related Issues
As I realized now, thumbnail display / downloading from the Qt UI is unchanged - it is fully separate codepath.
Related Pull Requests
#16040