Removal of thumbnail pack downloader related options #16096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thumbnail packs are no longer available, but the option was still present as "legacy thumbnail downloader". Since it serves no purpose any more, it is removed from the code.
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Thumbnail packs are no longer available, but the option was still present as "legacy thumbnail downloader". Since it serves no purpose any more, it is removed from the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thumbnail packs are no longer available - when enabling the legacy thumbnail downloader option, it could retrieve nothing nowadays. Since it serves no purpose any more, it is removed from the code.
I can update the PR to actually remove it already instead of "if 0" - it touches so many parts, I wanted to keep the code around for a while in case I missed some aspect and it needs to be re-added.
Related Pull Requests
#8844