Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu label finetunes #16144

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

zoltanvb
Copy link
Contributor

Description

Change quit sublabel depending on config save on exit status, it may be a bit more informative (or confusing?)
Update restart, file browser, menu driver sublabels.
Update config dir label and sublabel to be more exact and match other entries in the Directories list.
Restore quit help text display (noticed by accident).

Related Issues

Closes #16099
Closes #16104
Closes #16119

Reviewers

@davidhedlund

@davidhedlund
Copy link
Contributor

Description

Change quit sublabel depending on config save on exit status, it may be a bit more informative (or confusing?) Update restart, file browser, menu driver sublabels. Update config dir label and sublabel to be more exact and match other entries in the Directories list. Restore quit help text display (noticed by accident).

Related Issues

Closes #16099 Closes #16104 Closes #16119

Reviewers

@davidhedlund

Thank you very much for your contributions, I deeply appreciate it!

Best

@davidhedlund
Copy link
Contributor

davidhedlund commented Jan 20, 2024

Change quit sublabel depending on config save on exit status, it may be a bit more informative (or confusing?)

@zoltanvb, If this is going to be added, please read what I suggested here, I think this is simpler:

If: Settings -> Configuration -> Save Configuration on Quit: Disabled:

  • Label: "Quit. Sub label: Save Configuration on Quit is disabled."

@hizzlekizzle
Copy link
Contributor

oh nice, that was pretty painless to have it respond to the setting. I could see that being useful for a number of settings in the future.

Change quit sublabel depending on config save on exit status.
Update restart and menu driver sublabels.
Restore quit help text display.
@zoltanvb zoltanvb force-pushed the menu_name_improvements branch from 4809dd3 to 3133b83 Compare January 20, 2024 18:11
@zoltanvb
Copy link
Contributor Author

Updated quit sublabels. It is a convention that sublabel gives a slightly more verbose explanation of the option, so I kept that part as well.

@davidhedlund
Copy link
Contributor

davidhedlund commented Jan 22, 2024

Updated quit sublabels. It is a convention that sublabel gives a slightly more verbose explanation of the option, so I kept that part as well.

Not solved yet

Added to #16000 (comment) :

There are two types of configurations Save Configuration on Quit, and Save Remap Files on Quit:

image

The current text "Configuration save on exit is enabled/disabled." does not specify which configuration that is enabled or disabled. It should be updated to

  • Save Configuration on Quit is [enabled]/[disabled]// Distinguish from Save Remap Files on Quit (that I suggested here before) or
  • Save Configuration on Quit is [enabled]/[disabled], Save Remap Files on Quit is [enabled]/[disabled]

@LibretroAdmin LibretroAdmin merged commit 7a3c4a1 into libretro:master Jan 22, 2024
23 checks passed
@zoltanvb zoltanvb deleted the menu_name_improvements branch March 5, 2024 07:10
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this pull request Dec 26, 2024
Change quit sublabel depending on config save on exit status.
Update restart and menu driver sublabels.
Restore quit help text display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment