Fix ghost input when setting RETROK_UNKNOWN #16163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The L3 + R3 combo doesn't work and I think this is the cause. The latest working build is 48205d5 |
|
That was nasty, but this should cover it. |
This was referenced Feb 11, 2024
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since fixing each and every input driver to prevent them setting
RETROK_UNKNOWNkey down like Windows drivers already do, let's just try to ignore those inputs.I'm fairly confident it closes all these and maybe even more, though I only have tried by faking the unknown key with desktop. Please test that nothing else broke!
Related Issues
Closes #10071
Closes #10822
Closes #15626