Update alsa.h #17092
Open
Update alsa.h #17092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viachaslavic
suggested changes
Oct 12, 2024
Comment on lines
+27
to
+33
| typedef struct alsa_stream_info { | ||
| size_t buffer_size; | ||
| size_t period_size; | ||
| snd_pcm_uframes_t period_frames; | ||
| unsigned int frame_bits; | ||
| bool has_float; | ||
| bool can_pause; |
There was a problem hiding this comment.
Please follow the code style
viachaslavic
suggested changes
Oct 12, 2024
| bool alsa_stop_pcm(snd_pcm_t *pcm); | ||
|
|
||
| #endif /* RETROARCH_ALSA_H */ | ||
|
|
There was a problem hiding this comment.
Now the below code is redundant
RobLoach
reviewed
Jan 2, 2025
Comment on lines
+107
to
111
| #endif /* RETROARCH_ALSA_H */ | ||
|
|
||
| bool alsa_start_pcm(snd_pcm_t *pcm); | ||
| bool alsa_stop_pcm(snd_pcm_t *pcm); | ||
|
|
There was a problem hiding this comment.
As viachaslavic mentioned, likely don't need these last few lines, as the #endif is below
Suggested change
| #endif /* RETROARCH_ALSA_H */ | |
| bool alsa_start_pcm(snd_pcm_t *pcm); | |
| bool alsa_stop_pcm(snd_pcm_t *pcm); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.