Pointer sanitization: cocoa #17312
Merged
Pointer sanitization: cocoa #17312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cocoa driver specific changes: - make sure pointer position is always within [-0x7fff,0x7fff] by using the confined wrapper - enable pointer offscreen query
|
Let us know what you think @warmenhoven |
|
Taking a look now |
warmenhoven
approved these changes
Dec 30, 2024
|
lgtm. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the sanitized pointer handling, discussed at #17196 :
Cocoa driver specific changes:
Changes are minimal, since I have no means to actually test it, so this is now a minimal change set, to bring it in line with the other input drivers. After the PR, pointer input should never return -0x8000, but should indicate "offscreen" state near the edges, can be tested with Remote Retropad.
Leaving this in draft until confirmation is received.
Related Pull Requests
#17169 (comment)
Reviewers
@warmenhoven (testing is welcome from anyone)