Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow exact sync with shader subframes #17355

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

Tatsuya79
Copy link
Contributor

It's working somewhat, a bit hit or miss but better than nothing with games with particular timings.

@LibretroAdmin LibretroAdmin merged commit 43a2e10 into libretro:master Jan 6, 2025
27 checks passed
@Ophidon
Copy link
Contributor

Ophidon commented Jan 10, 2025

As the person who put that setting combination block in place, not sure I agree with this change. I would, for sure, if the alternative was actually 'nothing' as listed.

But there are 2 already existing ways to handle it. For basic 'casual' use there is increasing the maximum timing skew to allow resyncing from farther away.

And for someone who is really serious about syncing a game that is far enough that the timing skew would be a significant speed difference (like arcade MK running at 53Hz) and they insist on playing at the correct speed, while simultaneously also insisting on BFI/Sub-frames, there is an existing solution as well. You can create a custom resolution that is a multiple of the Hz for that game.

BFI/Sub-frames aren't tied to 50/60hz multiples in particular, that's just the most normal use case, they'll work correctly at exact multiples of any base sync rate.

Usually I'm all in for 'leave everything as an option, don't make decisions for the user they won't always agree with'. But in this instance, I think that:

  1. Having existing solutions to the problem (and in the case of the second above solution works essentially perfectly compared to the change from this PR that admits it only works 'somewhat'), and

  2. There will likely be an overwhelming percentage of users who won't understand, without a 10 page essay they'll never read, why enabling these 2 settings simultaneously could cause erratic flickering (or at least poor frame pacing for uses of sub-frames besides BFI) in a much wider scope of games and systems than those with unusual timings. Exact timings? Sounds great, hooray accuracy! BFI/Sub-frames allow for crt like motion clarity?! Also good! Hooray, 2 good things, gotta have both!

means that in this case it's best to leave the burden on the already high information users looking to solve this problem, to figure out to use either of the existing methods instead of opening this settings trap that will be easy to fall into for the lower infomation users, which for something fairly obscure and timing related like this will include nearly everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants