Allowing compilation on msys2 #17369
Conversation
## Description Before there was no clear way of running msys2, and even if there was, there is no guarantee of it working, well I fixed it, and added a CI, so that we can always know if it works. Furthermore I added 2 targets more: UCRT64 and CLANG64, yes, compilation with clang64 means we can also compile with clang for windows on arm :D, plus clang has better error messages overall, anyway. ## Related Issues libretro#17367 ## Reviewers Anyone, it's my first PR here.
|
|
|
This is cool. Seems like EDIT: Nevermind, guess you already mentioned that in the related issue. But the docs should probably be updated to suggest that UCRT64 or CLANG64 as the default MSYS2 environment: https://docs.libretro.com/development/retroarch/compilation/windows/ |
|
Should I update the docs? |
|
I think it makes sense. But I just started working with RetroArch yesterday, and also wondering why it was not using UCRT64/CLANG64 instead of the MINGW64 environment. |
|
I don't want to be too prescriptive, I'll let the retroarch team handle this for now, then :) Maybe in another PR |
|
I think the documentation can at least mention that UCRT64 and CLANG64 environments can also be used. |
|
In general, RA builds are using the oldest feasible environment, to make sure the end result runs on as many devices as possible. For self-compilation, maybe better to use the default (and update the doc), but submitted code should still compile against mingw64 (as well as a number of other environments). If the platform is added as new (Windows ARM), then there is no history, so the default can be something currently reasonable. |
|
@zoltanvb , can still have mingw64 environment used by the buildbot or CI checks, right? |
Description
Before there was no clear way of running msys2, and even if there was, there is no guarantee of it working, well I fixed it, and added a CI, so that we can always know if it works. Furthermore I added 2 targets more: UCRT64 and CLANG64, yes, compilation with clang64 means we can also compile with clang for windows on arm :D, plus clang has better error messages overall, anyway.
Related Issues
fixes #17367
Reviewers
Anyone, it's my first PR here.