Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libchdr to latest upstream. #230

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

negativeExponent
Copy link
Contributor

Fix #226

@hizzlekizzle
Copy link
Contributor

hey man, thanks for the libchdr update PRs! They are much appreciated.

Just so it's not a surprise, though: we probably won't be able to merge them for a while, as we basically have to update the libchdr in all of the cores and RetroArch all at once to avoid breaking the statically linked platforms (i.e., where the versions have to match).

So, if it's okay, just leave this PR open for a bit and we'll work toward getting everything ready for a big merge-blitz.

@LibretroAdmin
Copy link
Contributor

If it can be updated to a git subtree instead of a submodule there'd be an easier path to getting this merged

@negativeExponent
Copy link
Contributor Author

@hizzlekizzle @LibretroAdmin

I've sent a forced-push and replaced everything before with a subtree variant. For now im pushing it for PCE_FAST. Once its confirmed to be acceptable and ok, then ill forced-push the same things to Supergfax and Pce accuracy. then you can can check for compatibility issue with other platforms since i can do only linux and some windows (just for compiling)

@LibretroAdmin
Copy link
Contributor

OK just to let you know I haven't forgotten about this, sorry about the time but I will get to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of CHD to support ZSTD
3 participants