Update and refactor against upstream dolphin #352
+876,286
−1,044,666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 9d9b6d8 changed our target SDK version to Android 16, it made Android 16 stop calling onBackPressed and stop delivering KEYCODE_BACK events. Dolphin's code isn't ready for that yet. Android lets us opt out of this new behavior for now, so let's do so. But the opt-out will presumably stop working once we start targeting Android 17, so we're going to have to update Dolphin's code within the next one or two years to support the replacement API.
…tomic-interrupt HW/EXI_DeviceEthernet: Make interrupt state atomic.
…vements-pause-override Android: Don't let RetroAchievements override onPause
DolphinQt: Always enable the "Skip Main Menu" checkbox when "SkipIPL" is disabled.
…styles DolphinQt: Fix Windows dark theme when using external stylesheets.
Keep the BalloonTip open when the BalloonTip's arrow prevents the cursor from being inside the spawning ToolTipWidget, which triggers the ToolTipWidget's leaveEvent and would previously close the BalloonTip. When that happens track the cursor until it either leaves the ToolTipWidget's bounding box or leaves the BalloonTip and goes back to the ToolTipWidget, and respectively close the BalloonTip or leave it open.
Avoid map/set double lookups
…xpand_fix VideoCommon: fix regression in vertexshadergen for line/point expansion
MemoryWidget: Add Symbols and Notes.
…r-nearest VideoCommon: Fix "Force Nearest" texture filter setting.
…-hax ControllerEmu: Remove nunchuk stick data hax.
Invalidate icache only if target address has a different value. Take separate arguements, instead of a struct, to allow easier usage elsewhere. Overload with u8, u16 and u32 values for the same reason.
Compared to the former, the latter invalidates the icache, which is something that is likely desired for patches (especially if they are applied while the game is running).
PRs dolphin-emu#13786 and dolphin-emu#13797 had incompatible changes that resulted in the build being broken when they were both merged.
…fix_build_breakage_from_conflicting_prs MemoryWidget: Fix build breakage from conflicting PRs
…games_not_being_displayed Game List: Fix games not being displayed
Remove Host_UpdateMainFrame(). The only non-empty call happened in DolphinNoGUI which called s_update_main_frame_event.Set(), but DolphinNoGUI never waits on that event.
Remove Host_RefreshDSPDebuggerWindow (which hasn't done anything since DolphinWX was removed in 44b22c9) and DSP::Host::UpdateDebugger (which only called Host_RefreshDSPDebuggerWindow).
In certain cases, the platform can be "wayland-egl", "wayland-xcomposite", and other values for which I haven't found a full list yet. Instead of matching only "wayland", we now look for "wayland" anywhere in the `QT_QPA_PLATFORM` string in a case-insensitive manner. Acknowledgements: `CaseInsensitiveContains`' implementation was heavily inspired by GNU's non-standard glibc `strcasestr` function, which can be found here licensed under GPLv2 or later: https://ftp.gnu.org/gnu/libc/
…nnecessary_functions Host: Remove unnecessary functions
…re-loader BTReal: Implement Realtek firmware loading.
Android: Opt out of back invoked callback
…ric, and use it for a new "More Options..." selection in Bluetooth Passthrough adapters
Config: Change default value for Dual Core from enabled to disabled
…eam-drop-samples AudioCommon/Mixer: Skip sample processing when NullSoundStream is being used.
…nt-looping Fade audio after an entire loop
This case can be handled as a move. It also generates a constant carry flag. Before: 0x52800013 mov w19, #0x0 ; =0 0x6b1302b3 subs w19, w21, w19 After: 0x2a1503f3 mov w19, w21
|
Thank you @cscd98; great work! I've tested on Windows and it runs great for me. |
Rename m_session to m_last_value_session to better reflect its meaning and distinguish it from m_current_value_session which will be introduced in another commit.
…-fixes WiimoteReal/IOLinux: Improvements, fixes, and code cleanups.
…dget_small_refactoring CheatSearchWidget: Minor refactoring
cscd98
force-pushed
the
merge-clean-new
branch
6 times, most recently
from
bff3250 to
fa2e9a0
Compare
cscd98
force-pushed
the
merge-clean-new
branch
from
fa2e9a0 to
dc85d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussions are hidden under commits!! This happens when github comment is older than the commits which are re pushed occasionally for patches.
This is an attempt to rebase this on upstream dolphin. There is more than 10,000 commits since the last upstream merge so there is quite a lot of changes required to get this to work.
This PR is up to date with upstream as of Oct 4, 2025 (dolphin-emu#13871)
It boots up a selection of games that I've tried, runs pretty darn fast (except in debug mode).
Ubuntu was my main testing and development platform. Here is what has been tested:
Ubuntu:
Windows 11:
Android
macOS
iOS -iPhone/iPad
Not tested:
New Features
Future TODO
Cloning instructions
Ubuntu 25.10 using GCC 15.2
Windows 10/11
Windows 10/11 using ming
Cross compile from Ubuntu to Windows
Android
Shameless plug: If you want to thank or continue support for this please consider a small donation.. https://github.com/sponsors/cscd98