Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GNU Lightning 2024-11-02 #850

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

pcercuei
Copy link

@pcercuei pcercuei commented Nov 1, 2024

Update GNU Lightning to the latest upstream version.

One notable change is that the upstream version now supports SH4 processors, which I use in my downstream PCSX port for Dreamcast.

…ghtning.git --branch=master --update deps/lightning

subrepo:
  subdir:   "deps/lightning"
  merged:   "808fdde9e8"
upstream:
  origin:   "https://git.savannah.gnu.org/git/lightning.git"
  branch:   "master"
  commit:   "808fdde9e8"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo.git"
  commit:   "110b9eb"
Update the local lightning.h to a version generated from the latest
upstream.

Signed-off-by: Paul Cercueil <[email protected]>
@pcercuei
Copy link
Author

pcercuei commented Nov 1, 2024

I switched to the official GIT repo as well, so it seems to have undone the "gnulib" submodule, how can I fix that?

@notaz
Copy link
Collaborator

notaz commented Nov 2, 2024

Dunno, perhaps try git subrepo's --ALL option? Or maybe git rm deps/lightning/gnulib since it's not really needed (or is it?)? I wish libretro infra supported submodules already, this is an annoying difference from the master branch.

BTW I've meant to report this, but lightrec has problems with "Tomb Raider (USA) (Rev 2)" (http://redump.org/disc/12765/), when it loads it presents a menu from which the game doesn't start.

@pcercuei pcercuei force-pushed the update-lightning-20241102 branch 4 times, most recently from e4b5ef7 to ef3e68e Compare November 7, 2024 17:42
@notaz
Copy link
Collaborator

notaz commented Nov 14, 2024

Any plans to solve this? Perhaps keep the unwanted submodule, which is lesser evil than the reduced CI coverage.

@pcercuei
Copy link
Author

Yeah I was trying several things and could not get the CI to ignore the submodule. I'm on a motorcycle trip right now, will have a look when I get back.

@pcercuei pcercuei force-pushed the update-lightning-20241102 branch 2 times, most recently from aa5caed to 3271951 Compare November 28, 2024 12:14
We do not want nor need the "gnulib" submodule that comes with GNU
Lightning.

Signed-off-by: Paul Cercueil <[email protected]>
@pcercuei
Copy link
Author

Any plans to solve this? Perhaps keep the unwanted submodule, which is lesser evil than the reduced CI coverage.

Ok, I tried a few things to no avail. I give up, so I added gnulib as a submodule to fix the CI now.

@notaz notaz merged commit 568ad74 into libretro:master Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants