-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added and updated Ozone/Monochrome icons #432
base: master
Are you sure you want to change the base?
Conversation
Added and updated a lot of Ozone (PNG) and Monochrome (SVG+PNG) icons for themes. Full list in pull request.
Added missing PNG
revert Apple - Macintosh-content to 3.5" floppy (was changed to 5.25" floppy)
Resized icons to match current files (46x46 for main icons, 40x40 for content)
I really like the quality and consistency in the icons of the designs. @Jaffacakelover has done some excellent work as usual. My primary concern would be use of some logos in the designs. I worry that someday, Big Game companies might deliver a cease and desist for trademark infringement. There are lots of projects in the scene that are much more egregious, but Libretro might make for a higher profile target. That's probably a larger decision for the Libretro project leadership to weigh in on. Historically, @kivutar leaned toward leaving logos off of Monochrome icons unless it was absolutely necessary. I've always tried to follow that lead. I'm also not sure if all these icons should be contributed to Monochrome. This also has me questioning my recent contributions as well. Since Monochrome is the primary foundational set, the icons that are there are because they're listed in the Libretro database, they are a part of the No-Intro Dat-O-Matic or they provide some sort of functionality to the UI/UX. This set should focus on providing the project with all the necessary icons needed for current full functionality, along with icons for cores and functions that may be added in the immediate future. Nothing more and nothing less. Because it is the baseline set, I've always felt like any subsequent contributed theme should have 1-to-1 parity in order to properly qualify as a full set. That way, if an end user changes from Monochrome, it doesn't leave them with an ugly missing icon. It also means we should be careful to add only what is necessary for functionality. For the last little while, I've been trying for a while to bring Monochrome up to relative parity with FlatUX in anticipation that cores might be added in the future. But reviewing this PR helps me realize that objective is flawed and I have "taken my eye off the ball" of that core focus. In response to that self-criticism, I just opened Issue #433. That way, contributors to this repository as well as developers from the full team can weigh in and let us know what needs to be added and perhaps, what needs to be removed or left out of Monochrome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments on the PR.
Removed icons that would not be associated with a core in the near future
VMU icons have core available to be assigned to (VeMUlator)
Icons with no core to assign to
Updated Java ME with mobile phone icons, removed Arcade Controller as unused
Removed vitaVoyager (core no longer in repo)
I've removed "unnecessary" icons from this pr (see image, updated). I've also marked on the image which icons in this pr contain company logos. I set out updating icons over all themes at once (for parity) but hit a snag in the previous commits over the handling of NeoActive / RetroActive / RetroSystem themes (which were set to be merged into FlatUX). Is this now resolved?
|
I'd say option 1, with a few twists. Updating Monochrome is the A-1 priority for contributors. Since it's the primary baseline, it needs to be a complete set upon every release. Icons for UX functionality and soon-to-be-added cores take precedence. From there, work from the #433 to-do list based on the Libretro database, and the No-Intro Dat-O-Matic to help forge ahead. The next priority would be to work toward merging Monochrome and Ozone into what should become a #341 universal theme as well as the de-facto baseline theme. Perhaps we should call it "Monozone" when all is said and done. 😜 Last but not least, the community needs to decide if FlatUX is a "baseline theme" worthy of fulfilling the intended goal of #17 blazed by @gouchi and @kivutar. FlatUX could really use someone to take the lead by refining and blending the existing work, if you feel so inclined. We're ready to "pass the baton." Up to this point, Monochrome and FlatUI have been the themes where the community contributes. To my knowledge, all the other themes have been end-to-end creations by a single author. There haven't been any outside contributors, so you're blazing new trails by attempting to contribute to them all. Hopefully that helps to explain one of the reasons I've encouraged you to create your own theme. |
Already included as Apple - I and Apple - II
Reverting to current naming conventions
Hi @baxysquare So is it ready to be merged? Any comment on @baxysquare concerns in the above comments
|
Updated Ozone with matching deletions
Restored 2 icons used by core.. Renamed copies of 'Nintendo - Nintendo DSI (DLC)'.
Quake 2 Rogue, Xatrix and Zaero are listed as separate cores in Android RA
New Monochrome / Ozone icons. Combined with libretro#432 to complete libretro#433.
Hi there, Does this PR become obsolete by this one, or does this one still serve a purpose? Just asking. |
Yes, this commit has different files to #435, so adding both would be desired. |
This reverts commit e09f36d.
I'm really liking these! 🔥 |
The two Apple files aren't in my fork? Are they conflicting with another pull request? |
That is incredibly weird. The issue with the Philips CDi has been resolved but the Macintosh files still won't resolve with this pull or with #456, at least on my end. I've tried opening in GitHub Desktop and it will let me preview and create another pull request that says it's able to merge, but I'm guessing that will cause more problems, rather than solve them. @fpscan or @LibretroAdmin is this something you could help us with? Thanks for your patience as I'm clearly not a "GitHub master." |
Can we merge this? Btw, I suggest to rename Arduboy to "Arduboy Inc - Arduboy" according to database. |
All my pending icons for Retroarch's Ozone and Monochrome themes.
All PNGs compressed using Pingo
New icons for cores:
Apple - Macintosh II (minivmac)Apple - Macintosh II-content (minivmac)Apple - Macintosh (minivmac, alternate)Apple - Macintosh-content (minivmac, alternate)Atari - 800 (Atari800, aternate)Atari - 800-content (Atari800, aternate)Commodore - C64 (Frodo, renamed)Commodore - C64-content (Frodo, renamed)Gong-content (Gong)J2ME (SquirrelJME)J2ME-content (SquirrelJME)Nintendo - Nintendo DSi (Digital)Nintendo - Nintendo DSi (Digital)-contentStar Trek Voyager - Elite Force (vitaVoyager)Star Trek Voyager - Elite Force-content (vitaVoyager)The Powder Toy-content (The Powder Toy)Updated icons for cores:
New icons for GUI:
Extras
Arcade ControllerMicrosoft - Xbox SeriesMicrosoft - Xbox Series-contentNintendo - Wii U (Digital)Nintendo - Wii U (Digital)-contentSony - PlayStation 5Sony - PlayStation 5-contentSony - PlayStation Vita (DLC)Sony - PlayStation Vita (DLC)-contentSony - PlayStation Vita (PSN)Sony - PlayStation Vita (PSN)-contentSony - PocketStationSony - PocketStation-content