Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/datakbse 187 add manifest terms #289

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

sarwik
Copy link
Contributor

@sarwik sarwik commented May 31, 2021

Add mapping to IIIF presentation API 3.0 https://iiif.io/api/presentation/3.0/ and to Web Annotation Data Model https://www.w3.org/TR/annotation-model/.
For now we only have included the terms that we are using in data.kb.se (projekt "Öppna"), but more will be added based on the needs that projects "Tidningar" and "Visa" will identify.

  • I have built datasets

Note! Update 2021-06-01

After discussion, we (@andersju @klngwll @olovy @marlip @sarwik) have decided to pause this PR until after the summer. The reason is that there are many remaining questions regarding how we want to integrate with these vocabulary. "Öppna" is currently not dependent on us merging this PR - and with "Tidningar" and "Visa" the needs will hopefully be more clarified.

Comment on lines 17 to 18
:id owl:equivalentProperty iiif_pres3:id .
:type owl:equivalentProperty iiif_pres3:type .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are probably not defined in their (non-RDF-documented) vocabulary. I gather you've taken them from their specific JSON-LD-context? They are only defined there as aliases of @id and @type. We (as in XL) do not use such aliases in the default context that we associate with KBV (and use throughout in XL). Of course anyone using KBV from another system-specific context are free to use any particular forms of JSON they need (ideally with motivations), as long as we keep the contexts separate (though one can build on another).

In any case, they should not be added as terms to KBV (nor as aliases to the XL default context at id.kb.se).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to know! Exactly, we have taken them from JSON-LD context and missed that they are aliases. I will remove them.

@marlip marlip force-pushed the feature/DATAKBSE-187-add-Manifest-terms branch from c1a0f51 to 5c2a506 Compare July 29, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants