Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a11y enums and update vocab terms #291

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Add a11y enums and update vocab terms #291

wants to merge 1 commit into from

Conversation

klngwll
Copy link
Contributor

@klngwll klngwll commented Jun 1, 2021 •
edited
Loading

  • Add a11y enums
  • Update vocab terms
  • Update display

niklasl
niklasl reviewed Oct 13, 2021
View reviewed changes
source/vocab/display.jsonld
@@ -97,7 +97,7 @@
"@id": "AccessModeType-chips",
"@type": "fresnel:Lens",
"classLensDomain": "AccessModeType",
"showProperties": [ "code" ]
"showProperties": [ "notation" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be code (we use the BF nomenclature IIRC, which we map to skos:notation; look at these resources as JSON-LD after the dataset's been built to verify this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasl niklasl niklasl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klngwll @niklasl