Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeatable for used hasHold9XX fields and subfields #385

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

klngwll
Copy link
Contributor

@klngwll klngwll commented Jul 1, 2022

All marc:marc:hasHold9XX fields and subfields are repeatable according to https://katalogverk.kb.se/katalogisering/Formathandboken/Bestand/9XX/index.html

I have added only those appearing in our validation report of Unexpected array. Key is not declared as repeatable in context for hold to see if any new ones appear. Hopefully down the road these will be redundant anyway.

@klngwll klngwll requested review from niklasl and lrosenstrom July 1, 2022 09:52
@klngwll klngwll requested a review from kwahlin November 1, 2022 09:16
@niklasl
Copy link
Member

niklasl commented Nov 1, 2022

Since these are really just generated placeholders that should never see the light of day in usage, I'd rather work around them in the validation, or even filter them out. Declaring them in the context exposes them even more (when we ought to work to remove them). If these are ever to be explicitly used in the client, we need to mint proper terms for them.

@niklasl
Copy link
Member

niklasl commented Nov 1, 2022

I guess silencing them is problematic if we turn on the (here a bit overly strict, standards-wise) validation though. And if we get around to applying the context for normalizing on save, that would remove the wrapping array if there is only one value.

Could we attempt go get rid of at least some of these in one way or another, and only declare the ones that must be kept? (Ideally renaming them if so, though that might not give us so much more value...)

@klngwll
Copy link
Contributor Author

klngwll commented Nov 2, 2022

I guess silencing them is problematic if we turn on the (here a bit overly strict, standards-wise) validation though. And if we get around to applying the context for normalizing on save, that would remove the wrapping array if there is only one value.

Could we attempt go get rid of at least some of these in one way or another, and only declare the ones that must be kept? (Ideally renaming them if so, though that might not give us so much more value...)

I agree we could take another round to check usage and relevance today. Leave this PR as a reminder for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants