Skip to content

Add agent membership properties #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

niklasl
Copy link
Member

@niklasl niklasl commented May 12, 2025

For use on agents, mainly to relate to parent organization.

(Including commented suggestions of OWL entailment axioms mapping to RDA equivalents (by type).)

  • Add :hasMember and :isMemberOf.
  • The needs (and uses of e.g. Corporation) of these entailments need to be verified (and reasonably either marked as abstract, pending and/or turned into bnodes). (We can also comment them out if we're good with the basic properties.)

@niklasl niklasl requested a review from klngwll May 14, 2025 15:08
@niklasl niklasl requested a review from branchedelac May 23, 2025 14:12
@niklasl niklasl force-pushed the feature/agent-membership-properties branch 2 times, most recently from 8fd8a41 to 0af9da3 Compare May 27, 2025 08:52
@niklasl niklasl marked this pull request as ready for review May 27, 2025 08:54
@niklasl niklasl force-pushed the feature/agent-membership-properties branch 2 times, most recently from a85be28 to 68b3277 Compare May 27, 2025 09:03
@niklasl niklasl changed the title Add agent membership properties [WIP] Add agent membership properties May 27, 2025
@niklasl niklasl force-pushed the feature/agent-membership-properties branch from 68b3277 to 1091bf7 Compare May 27, 2025 09:25
:isMemberOf a owl:ObjectProperty ;
rdfs:label "är medlem av"@sv , "is member of"@en ;
sdo:domainIncludes :Agent ;
sdo:rangeIncludes :Organization ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not family?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just answered my own question with my last comment I guess? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added :Family too.

rdfs:label "har medlem"@sv , "has member"@en ;
sdo:domainIncludes :Organization, :Family ;
sdo:rangeIncludes :Agent ;
owl:equivalentProperty sdo:member ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdo seems not to include family when talking about member so equivalent is maybe not right.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not; but they're just "*includes", so it's not meaningful beyond structural hints (which aren't entailed).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop :Family and only suggest :Person and :Organization rather than :Agent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed; keeping as is (noting they're just hints anyway).

Including mappings to SDO and suggested OWL entailment rules for RDA
equivalents (by type).
@niklasl niklasl force-pushed the feature/agent-membership-properties branch from 1091bf7 to 77d17e4 Compare May 27, 2025 12:13
Copy link
Contributor

@klngwll klngwll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niklasl niklasl merged commit 7fe5c92 into develop May 27, 2025
@niklasl niklasl deleted the feature/agent-membership-properties branch May 27, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants