Feature/lxl 4279 #1325
Merged
Feature/lxl 4279 #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put "cluster bound" script in librisworks/run.sh and not cluster bound script in whelktool/globalchanges-1.33.sh
* If the work title of one record matches the instance title of another record, these two records now ends up in the same cluster. * Use existing methods in find-work-clusters.groovy instead of declaring new ones.
* Cluster by titles before merging overlapping clusters * Side effect: Necessary to make Elastic queries from each record individually in first clustering step
kwahlin
force-pushed
the
feature/lxl-4279
branch
from
c12f41f to
7f90c3c
Compare
olovy
reviewed
Nov 15, 2023
librisworks/src/main/groovy/se/kb/libris/mergeworks/Util.groovy
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should cover https://jira.kb.se/browse/LXL-4279. See individual commits.
Regarding a4c8bba and 6dd287a: All scripts don't necessarily have to be run during the release, I just think it's good to keep all the "preparation" scripts in one place and we can figure out exactly how to roll them out when we plan the release.